add option for listing customers without a balance (closes: RT#2752) and fix bug in total row (closes: RT#2736)

2 files changed, 94 insertions, 78 deletions

diff --git a/httemplate/search/report_receivables.cgi b/httemplate/search/report_receivables.cgi
index a944c6e67..8c5236342 100755
--- a/httemplate/search/report_receivables.cgi
+++ b/httemplate/search/report_receivables.cgi
@@ -83,61 +83,6 @@
 
              )
 %>
-<%once>
-
-sub owed {
-  my($start, $end, %opt) = @_;
-
-  my @where = ();
-
-  #handle start and end ranges
-
-  my $str2time = str2time_sql;
-
-  #24h * 60m * 60s
-  push @where, "cust_bill._date <= $str2time now() ) - ". ($start * 86400)
-    if $start;
-
-  push @where, "cust_bill._date >  $str2time now() ) - ". ($end * 86400)
-    if $end;
-
-  #handle 'cust' option
-
-  push @where, "cust_main.custnum = cust_bill.custnum"
-    if $opt{'cust'};
-
-  #handle 'agentnum' option
-  my $join = '';
-  if ( $opt{'agentnum'} ) {
-    $join = 'LEFT JOIN cust_main USING ( custnum )';
-    push @where, "agentnum = '$opt{'agentnum'}'";
-  }
-
-  my $where = scalar(@where) ? 'WHERE '.join(' AND ', @where) : '';
-
-  my $as = $opt{'noas'} ? '' : "as owed_${start}_$end";
-
-  my $charged = <<END;
-sum( charged
-     - coalesce(
-         ( select sum(amount) from cust_bill_pay
-           where cust_bill.invnum = cust_bill_pay.invnum )
-         ,0
-       )
-     - coalesce(
-         ( select sum(amount) from cust_credit_bill
-           where cust_bill.invnum = cust_credit_bill.invnum )
-         ,0
-       )
-
-   )
-END
-
-  "coalesce( ( select $charged from cust_bill $join $where ) ,0 ) $as";
-
-}
-
-</%once>
 <%init>
 
 die "access denied"
@@ -168,22 +113,29 @@ my $packages_cols = <<END;
      ( $select_count_pkgs AND $cancelled_sql ) AS cancelled_pkgs
 END
 
-my $days = 0;
-if ( $cgi->param('days') =~ /^\s*(\d+)\s*$/ ) {
-  $days = $1;
-}
+my @where = ();
+
+unless ( $cgi->param('all_customers') ) {
+
+  my $days = 0;
+  if ( $cgi->param('days') =~ /^\s*(\d+)\s*$/ ) {
+    $days = $1;
+  }
 
-#my $where = "where ". owed(0, 0, 'cust'=>1, 'noas'=>1). " > 0";
-my $where = "where ". owed($days, 0, 'cust'=>1, 'noas'=>1). " > 0";
+  push @where, owed($days, 0, 'cust'=>1, 'noas'=>1). " > 0";
+
+}
 
-my $agentnum = '';
 if ( $cgi->param('agentnum') =~ /^(\d+)$/ ) {
-  $agentnum = $1;
-  $where .= " AND agentnum = '$agentnum' ";
+  my $agentnum = $1;
+  push @where, "agentnum = $agentnum";
 }
 
 #here is the agent virtualization
-$where .= ' AND '. $FS::CurrentUser::CurrentUser->agentnums_sql;
+push @where, $FS::CurrentUser::CurrentUser->agentnums_sql;
+
+my $where = join(' AND ', @where);
+$where = "WHERE $where" if $where;
 
 my $count_sql = "select count(*) from cust_main $where";
 
@@ -194,8 +146,10 @@ my $sql_query = {
   'extra_sql' => "$where order by coalesce(lower(company), ''), lower(last)",
 };
 
+my $join = 'LEFT JOIN cust_main USING ( custnum )';
+
 my $total_sql = "select ".
-                  join(',', map owed( @$_, 'agentnum'=>$agentnum ), @ranges );
+  join(',', map owed( @$_, join=>$join, where=>\@where ), @ranges);
 
 my $total_sth = dbh->prepare($total_sql) or die dbh->errstr;
 $total_sth->execute or die "error executing $total_sql: ". $total_sth->errstr;
@@ -227,3 +181,56 @@ my $status_statuscol = sub {
 };
 
 </%init>
+<%once>
+
+sub owed {
+  my($start, $end, %opt) = @_;
+
+  my @where = ();
+
+  #handle start and end ranges
+
+  my $str2time = str2time_sql;
+
+  #24h * 60m * 60s
+  push @where, "cust_bill._date <= $str2time now() ) - ". ($start * 86400)
+    if $start;
+
+  push @where, "cust_bill._date >  $str2time now() ) - ". ($end * 86400)
+    if $end;
+
+  #handle 'cust' option
+  push @where, "cust_main.custnum = cust_bill.custnum"
+    if $opt{'cust'};
+
+  #handle 'join' option
+  my $join = $opt{'join'} || '';
+
+  #handle 'where' option
+  push @where, @{ $opt{'where'} } if $opt{'where'};
+
+  my $where = scalar(@where) ? 'WHERE '.join(' AND ', @where) : '';
+
+  my $as = $opt{'noas'} ? '' : "as owed_${start}_$end";
+
+  my $charged = <<END;
+sum( charged
+     - coalesce(
+         ( select sum(amount) from cust_bill_pay
+           where cust_bill.invnum = cust_bill_pay.invnum )
+         ,0
+       )
+     - coalesce(
+         ( select sum(amount) from cust_credit_bill
+           where cust_bill.invnum = cust_credit_bill.invnum )
+         ,0
+       )
+
+   )
+END
+
+  "coalesce( ( select $charged from cust_bill $join $where ) ,0 ) $as";
+
+}
+
+</%once>
diff --git a/httemplate/search/report_receivables.html b/httemplate/search/report_receivables.html
index bb23f1f87..56097534f 100755
--- a/httemplate/search/report_receivables.html
+++ b/httemplate/search/report_receivables.html
@@ -1,23 +1,32 @@
 <% include('/elements/header.html', 'Accounts Receivable Aging Summary' ) %>
 
-    <FORM ACTION="report_receivables.cgi" METHOD="GET">
+<FORM NAME="OneTrueForm" ACTION="report_receivables.cgi" METHOD="GET">
 
-    <TABLE>
+<TABLE BGCOLOR="#cccccc" CELLSPACING=0>
 
-      <% include( '/elements/tr-select-agent.html' ) %>
+  <TR>
+    <TH BGCOLOR="#e8e8e8" COLSPAN=2 ALIGN="left">
+      <FONT SIZE="+1">Search options</FONT>
+    </TH>
+  </TR>
 
-      <TR>
-        <TD ALIGN="right">Over </TD>
-        <TD><INPUT NAME="days" TYPE="text" SIZE=4 MAXLENGTH=3> days</TD>
-      </TR>
+  <% include( '/elements/tr-select-agent.html' ) %>
+  
+  <TR>
+    <TD ALIGN="right">Customers</TD>
+    <TD>
+      <INPUT TYPE="radio" NAME="all_customers" VALUE="1" onClick="if (this.checked) { document.OneTrueForm.days.disabled=true; } else { document.OneTrueForm.days.disabled=false; }">All customers (even those without an outstanding balance)<BR>
+      <INPUT TYPE="radio" NAME="all_customers" VALUE="0" CHECKED onClick="if (this.checked) { document.OneTrueForm.days.disabled=false; } else { document.OneTrueForm.days.disabled=true; }">Customers with a balance over <INPUT NAME="days" TYPE="text" SIZE=4 MAXLENGTH=3 VALUE="0"> days old
+    </TD>
+  </TR>
 
-    </TABLE>
+</TABLE>
 
-    <BR><INPUT TYPE="submit" VALUE="Get Report">
-    </FORM>
+<BR><INPUT TYPE="submit" VALUE="Get Report">
+</FORM>
+
+<% include('/elements/footer.html') %>
 
-  </BODY>
-</HTML>
 <%init>
 
 die "access denied"