much more efficient event migration: let the database do the work, RT#5426

1 files changed, 33 insertions, 35 deletions

diff --git a/bin/freeside-migrate-events b/bin/freeside-migrate-events
index 522d4b17c..3e8a6b209 100644
--- a/bin/freeside-migrate-events
+++ b/bin/freeside-migrate-events
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 
 use strict;
-use Getopt::Std;
+#use Getopt::Std;
 use FS::UID qw( adminsuidsetup dbh );
 use FS::Record qw( qsearch );
 use FS::part_bill_event;
@@ -9,8 +9,8 @@ use FS::part_event;
 use FS::cust_bill_event;
 use FS::cust_event;
 
-use vars qw( $opt_m );
-getopts('m');
+#use vars qw( $opt_m );
+#getopts('m');
 
 my $user = shift or die &usage;
 adminsuidsetup($user);
@@ -142,9 +142,7 @@ foreach my $part_bill_event (
   #my $derror = $part_bill_event->delete;
   #die "error removing part_bill_event: $derror\n" if $derror;
 
-  if ( $opt_m ) {
-
-    #this should probably just become the default once we're sure it works 100%
+#  if ( $opt_m ) {
 
     my $sth = dbh->prepare('
       INSERT INTO cust_event ( eventpart, tablenum, _date, status, statustext )
@@ -155,35 +153,35 @@ foreach my $part_bill_event (
     $sth->execute( $part_event->eventpart, $part_bill_event->eventpart )
       or die $sth->errstr;
 
-  } else {
-
-    foreach my $cust_bill_event (
-      qsearch({
-        'table'     => 'cust_bill_event',
-        'hashref'   => { 'eventpart' => $part_bill_event->eventpart, },
-      })
-    ) {
-
-      my $cust_event = new FS::cust_event {
-        'eventpart'  => $part_event->eventpart,
-        'tablenum'   => $cust_bill_event->invnum,
-        '_date'      => $cust_bill_event->_date,
-        'status'     => $cust_bill_event->status,
-        'statustext' => $cust_bill_event->statustext,
-      };
-
-      my $cerror = $cust_event->insert;
-      #die "error inserting cust_event: $cerror\n" if $cerror;
-      warn "error inserting cust_event: $cerror\n" if $cerror;
-    
-      #my $dcerror = $cust_bill_event->delete;
-      #die "error removing cust_bill_event: $dcerror\n" if $dcerror;
-
-      print ".";
-
-    }
-
-  }
+#  } else {
+#
+#    foreach my $cust_bill_event (
+#      qsearch({
+#        'table'     => 'cust_bill_event',
+#        'hashref'   => { 'eventpart' => $part_bill_event->eventpart, },
+#      })
+#    ) {
+#
+#      my $cust_event = new FS::cust_event {
+#        'eventpart'  => $part_event->eventpart,
+#        'tablenum'   => $cust_bill_event->invnum,
+#        '_date'      => $cust_bill_event->_date,
+#        'status'     => $cust_bill_event->status,
+#        'statustext' => $cust_bill_event->statustext,
+#      };
+#
+#      my $cerror = $cust_event->insert;
+#      #die "error inserting cust_event: $cerror\n" if $cerror;
+#      warn "error inserting cust_event: $cerror\n" if $cerror;
+#    
+#      #my $dcerror = $cust_bill_event->delete;
+#      #die "error removing cust_bill_event: $dcerror\n" if $dcerror;
+#
+#      print ".";
+#
+#    }
+#
+#  }
 
   print "\n";