diff options
| author | ivan <ivan> | 2006-09-13 14:53:01 +0000 |
|---|---|---|
| committer | ivan <ivan> | 2006-09-13 14:53:01 +0000 |
| commit | d77dad830dda5fbe6d807445e09fe6770efdb550 (patch) | |
| tree | a21f6948acd590ee952ab1a78247de528df46cfe | |
| parent | 201c446a69a498dd2fe61206ca7d04d930c497b5 (diff) | |
some cleanup while i'm here
| -rw-r--r-- | FS/FS/cust_credit.pm | 10 | ||||
| -rw-r--r-- | FS/FS/cust_pay.pm | 19 |
2 files changed, 21 insertions, 8 deletions
diff --git a/FS/FS/cust_credit.pm b/FS/FS/cust_credit.pm index 9cc92d2..7ffb1d1 100644 --- a/FS/FS/cust_credit.pm +++ b/FS/FS/cust_credit.pm @@ -134,10 +134,13 @@ sub insert { =item delete -Currently unimplemented. +Unless the closed flag is set, deletes this credit and all associated +applications (see L<FS::cust_credit_bill>). In most cases, you want to use +the void method instead to leave a record of the deleted credit. =cut +# very similar to FS::cust_pay::delete sub delete { my $self = shift; return "Can't delete closed credit" if $self->closed =~ /^Y/i; @@ -169,7 +172,7 @@ sub delete { if ( $conf->config('deletecredits') ne '' ) { - my $cust_main = qsearchs('cust_main',{ 'custnum' => $self->custnum }); + my $cust_main = $self->cust_main; my $error = send_email( 'from' => $conf->config('invoice_from'), #??? well as good as any @@ -203,8 +206,7 @@ sub delete { =item replace OLD_RECORD -Credits may not be modified; there would then be no record the credit was ever -posted. +You can, but probably shouldn't modify credits... =cut diff --git a/FS/FS/cust_pay.pm b/FS/FS/cust_pay.pm index f057d2f..bc5fbab 100644 --- a/FS/FS/cust_pay.pm +++ b/FS/FS/cust_pay.pm @@ -272,12 +272,14 @@ sub void { =item delete -Deletes this payment and all associated applications (see L<FS::cust_bill_pay>), -unless the closed flag is set. In most cases, you want to use the void -method instead to leave a record of the deleted payment. +Unless the closed flag is set, deletes this payment and all associated +applications (see L<FS::cust_bill_pay> and L<FS::cust_pay_refund>). In most +cases, you want to use the void method instead to leave a record of the +deleted payment. =cut +# very similar to FS::cust_credit::delete sub delete { my $self = shift; return "Can't delete closed payment" if $self->closed =~ /^Y/i; @@ -345,7 +347,16 @@ sub delete { =item replace OLD_RECORD -You probably shouldn't modify payments... +You can, but probably shouldn't modify payments... + +=cut + +sub replace { + #return "Can't modify payment!" + my $self = shift; + return "Can't modify closed payment" if $self->closed =~ /^Y/i; + $self->SUPER::replace(@_); +} =item check |