diff options
author | ivan <ivan> | 2011-05-11 00:49:50 +0000 |
---|---|---|
committer | ivan <ivan> | 2011-05-11 00:49:50 +0000 |
commit | 9c6d500c5fc6704e6186caa8727e79e7c600bd8a (patch) | |
tree | 11ed04c9ff1b971c38ea66e6e1ce44e60272555d | |
parent | 2f864a9b428d642df650d01a51ffa42b6826d82a (diff) |
removing code that deleted pending payments. a real wtf. RT#12662
-rw-r--r-- | FS/FS/cust_main/Billing_Realtime.pm | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm index 500d2c2..caa3ab3 100644 --- a/FS/FS/cust_main/Billing_Realtime.pm +++ b/FS/FS/cust_main/Billing_Realtime.pm @@ -522,24 +522,6 @@ sub realtime_bop { 'custnum' => $self->custnum, 'status' => { op=>'!=', value=>'done' } }); - # This is a problem. A self-service third party payment that fails somehow - # can't be retried, EVER, until someone manually clears it. Totally - # arbitrary fix: if the existing payment is more than two minutes old, - # kill it. This doesn't limit how long it can take the pending payment - # to complete, only how long it will obstruct new payments. - my @still_pending; - foreach (@pending) { - if ( time - $_->_date > 120 ) { - my $error = $_->delete; - warn "error deleting stale pending payment ".$_->paypendingnum.": $error" - if $error; # not fatal, it will fail anyway - } - else { - push @still_pending, $_; - } - } - @pending = @still_pending; - return "A payment is already being processed for this customer (". join(', ', map 'paypendingnum '. $_->paypendingnum, @pending ). "); $options{method} transaction aborted." |