diff options
| author | Ivan Kohler <ivan@freeside.biz> | 2017-02-01 14:49:03 -0800 |
|---|---|---|
| committer | Jonathan Prykop <jonathan@freeside.biz> | 2017-02-01 17:29:01 -0600 |
| commit | 090f86537bd81e8194c5e75dec43208ca0a5944a (patch) | |
| tree | d5158ea2630c837fa4bad4b701c63df11c7506db | |
| parent | bd1d715bf1d1c192c79413998b6f3e75d8252777 (diff) | |
never blank an existing paycardtype inadvertantly
| -rw-r--r-- | FS/FS/cust_payby.pm | 6 | ||||
| -rw-r--r-- | FS/FS/payinfo_Mixin.pm | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/FS/FS/cust_payby.pm b/FS/FS/cust_payby.pm index e25d73e..136acf1 100644 --- a/FS/FS/cust_payby.pm +++ b/FS/FS/cust_payby.pm @@ -357,14 +357,14 @@ sub check { or return gettext('invalid_card'); # . ": ". $self->payinfo; # see parallel checks in check_payinfo_cardtype & payinfo_Mixin::payinfo_check - my $cardtype = ''; + my $cardtype = $self->paycardtype; if ( $self->tokenized ) { if ( $self->paymask =~ /^\d+x/ ) { $cardtype = cardtype($self->paymask); } else { - $cardtype = ''; #return "paycardtype required ". - # "(can't derive from a token and no paymask w/prefix provided)"; + # "(can't derive from a token and no paymask w/prefix provided)" + # unless $cardtype; } } else { $cardtype = cardtype($self->payinfo); diff --git a/FS/FS/payinfo_Mixin.pm b/FS/FS/payinfo_Mixin.pm index cb9b723..84759cc 100644 --- a/FS/FS/payinfo_Mixin.pm +++ b/FS/FS/payinfo_Mixin.pm @@ -202,7 +202,7 @@ sub payinfo_check { if ( $self->paymask =~ /^\d+x/ ) { $self->set('paycardtype', cardtype($self->paymask)); } else { - $self->set('paycardtype', ''); + $self->set('paycardtype', '') unless $self->paycardtype; #return "paycardtype required ". # "(can't derive from a token and no paymask w/prefix provided)"; } @@ -233,7 +233,7 @@ sub payinfo_check { # if we can't decrypt the card, at least detect the cardtype $self->set('paycardtype', cardtype($self->paymask)); } else { - $self->set('paycardtype', ''); + $self->set('paycardtype', '') unless $self->paycardtype; # return "paycardtype required ". # "(can't derive from a token and no paymask w/prefix provided)"; } |