summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorivan <ivan>2009-11-25 19:58:49 +0000
committerivan <ivan>2009-11-25 19:58:49 +0000
commit9406701ac3be0d78e44d661b4a132f5a9da23079 (patch)
tree27294ea1dcdbe731dc86ea45dcc701369f442ff9
parentd114bf1bb1b929a166b7ed98be4f94369d32a535 (diff)
don't consider disabled report classes, don't load up the whole table just to see if there are any
-rwxr-xr-xhttemplate/edit/part_pkg.cgi12
1 files changed, 11 insertions, 1 deletions
diff --git a/httemplate/edit/part_pkg.cgi b/httemplate/edit/part_pkg.cgi
index fcde22bf6..7140ca500 100755
--- a/httemplate/edit/part_pkg.cgi
+++ b/httemplate/edit/part_pkg.cgi
@@ -247,6 +247,11 @@ my $begin_callback = sub {
my $disabled_type = $acl_edit_either ? 'checkbox' : 'hidden';
+#arg. access rights for cloning are Hard.
+# on the one hand we don't really want cloning (customizing a package) to fail
+# for want of finding the source package in normal usage
+# on the other hand, we don't want people using the clone link to be able to
+# see
my $agent_clone_extra_sql =
' ( '. FS::part_pkg->curuser_pkgs_sql.
" OR ( part_pkg.custom = 'Y' ) ".
@@ -254,7 +259,12 @@ my $agent_clone_extra_sql =
my $conf = new FS::Conf;
my $taxproducts = $conf->exists('enable_taxproducts');
-my $census = scalar( qsearch( 'part_pkg_report_option', {} ) );
+
+my $sth = dbh->prepare("SELECT COUNT(*) FROM part_pkg_report_option".
+ " WHERE disabled IS NULL OR disabled = '' ")
+ or die dbh->errstr;
+$sth->execute or die $sth->errstr;
+my $census = $sth->fetchrow_arrayref->[0];
#XXX
# - tr-part_pkg_freq: month_increments_only (from price plans)