diff options
| author | Jonathan Prykop <jonathan@freeside.biz> | 2016-12-28 13:56:31 -0600 |
|---|---|---|
| committer | Jonathan Prykop <jonathan@freeside.biz> | 2017-01-03 21:06:08 -0600 |
| commit | 4d79aed4700a31d339bef938e4b2490ff8f2b9ec (patch) | |
| tree | 8a40795b0e44c330e627e72804d2749c243529b2 | |
| parent | 2a565ea54a0af5f32ac26804be62249effa958bf (diff) | |
71513: Card tokenization [undid refund always sending token, skip token_check if nothing is tokenizable]
| -rw-r--r-- | FS/FS/cust_main/Billing_Realtime.pm | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm index 453cd71..a4622f5 100644 --- a/FS/FS/cust_main/Billing_Realtime.pm +++ b/FS/FS/cust_main/Billing_Realtime.pm @@ -1598,12 +1598,6 @@ sub realtime_refund_bop { $content{'name'} = $self->get('first'). ' '. $self->get('last'); } } - if ( $cust_pay->payby eq 'CARD' - && !$content{'card_number'} - && $cust_pay->tokenized - ) { - $content{'card_token'} = $cust_pay->payinfo; - } $void->content( 'action' => 'void', %content ); $void->test_transaction(1) if $conf->exists('business-onlinepayment-test_transaction'); @@ -2423,8 +2417,9 @@ sub token_check { my $cache = {}; #cache for module info - # look for a gateway that can't tokenize + # look for a gateway that can and can't tokenize my $require_tokenized = 1; + my $someone_tokenizing = 0; foreach my $gateway ( FS::payment_gateway->all_gateways( 'method' => 'CC', @@ -2436,18 +2431,26 @@ sub token_check { # no default gateway, no promise to tokenize # can just load other gateways as-needeed below $require_tokenized = 0; - last; + last if $someone_tokenizing; + next; } my $info = _token_check_gateway_info($cache,$gateway); die $info unless ref($info); # means it's an error message - unless ($info->{'can_tokenize'}) { + if ($info->{'can_tokenize'}) { + $someone_tokenizing = 1; + } else { # a configured gateway can't tokenize, that's all we need to know right now # can just load other gateways as-needeed below $require_tokenized = 0; - last; + last if $someone_tokenizing; } } + unless ($someone_tokenizing) { #no need to check, if no one can tokenize + warn "no gateways tokenize\n" if $debug; + return; + } + warn "REQUIRE TOKENIZED" if $require_tokenized && $debug; # upgrade does not call this with autocommit turned on, |