add "Summarize packages" ACL, RT#16534

1 files changed, 13 insertions, 6 deletions

diff --git a/FS/FS/access_right.pm b/FS/FS/access_right.pm
index d2a39aac8..341055bfc 100644
--- a/FS/FS/access_right.pm
+++ b/FS/FS/access_right.pm
@@ -182,23 +182,30 @@ sub _upgrade_data { # class method
 
   my @all_groups = qsearch('access_group', {});
 
-  ### ACL_list_all_customers
-  if ( !FS::upgrade_journal->is_done('ACL_list_all_customers') ) {
+  my %onetime = (
+    'List customers' => 'List all customers',
+    'List packages'  => 'Summarize packages',
+  );
+
+  foreach my $old_acl ( keys %onetime ) {
+    my $new_acl = $onetime{$old_acl}; #support arrayref too?
+    ( my $journal = 'ACL_'.lc($new_acl) ) =~ s/ /_/g;
+    next if FS::upgrade_journal->is_done($journal);
 
-    # grant "List all customers" to all users who have "List customers"
+    # grant $new_acl to all groups who have $old_acl
     for my $group (@all_groups) {
-      if ( $group->access_right('List customers') ) {
+      if ( $group->access_right($old_acl) ) {
         my $access_right = FS::access_right->new( {
             'righttype'   => 'FS::access_group',
             'rightobjnum' => $group->groupnum,
-            'rightname'   => 'List all customers',
+            'rightname'   => $new_acl,
         } );
         my $error = $access_right->insert;
         die $error if $error;
       }
     }
     
-    FS::upgrade_journal->set_done('ACL_list_all_customers');
+    FS::upgrade_journal->set_done($journal);
   }
 
   ### ACL_download_report_data